Problems with the Hammerne staff and the skill patch

Jonah_07 · February 2, 2024, 7:33pm

Hacking method: Febuilder

Base Game:FE8

While testing the rom I noticed that the hammerne staff would make the rom crash if used a 2 range (staff savant skill).
Is there a way to avoid the crash while still be able to use the hammerne staff at 2 range ?

Vesly · February 2, 2024, 11:46pm

This is the vanilla function where it makes a target list for adjacent units with hammerne:

github.com

FireEmblemUniverse/fireemblem8u/blob/27a697610a46e2961f4d9ed3c37263252280d78a/src/bmtarget.c#L1191


      
          }
          
          void MakeTargetListForHammerne(struct Unit* unit) {
              int x = unit->xPos;
              int y = unit->yPos;
          
              gSubjectUnit = unit;
          
              BmMapFill(gBmMapRange, 0);
          
              ForEachAdjacentUnit(x, y, TryAddUnitToHammerneTargetList);
          
              return;
          }
          
          void MakeTargetListForLatona(struct Unit* unit) {
              int phase;
              int i;
          
              InitTargets(unit->xPos, unit->yPos);

Looks like skillsys doesn’t hook this, which means the target list is only made for adjacent units. I think it might be easiest to just disable hammerne from having extended range, but I’ll link this thread in skillsys dev as an issue.