How do I change Vanage to not cancel crit

Alice · December 18, 2023, 10:47am

In the default skillsystems, when a unit is under the effect of Vantage, they are unable to crit. How would I go about changing this so they have their normal crit rate?

I am using the Github skillsystems buildfile. What part of the Vantage code do I have to edit?

Contro · December 18, 2023, 10:51am

Comment out or remove this section.

github.com

FireEmblemUniverse/SkillSystem_FE8/blob/cad6f499b0009a002997784a64ecab7cf7c57c2d/EngineHacks/SkillSystem/Skills/StandaloneSkills/Vantage/vantage.s#L64


      
          @ orr     r0,r1                @ 0802B438 4308     
          @ str     r0,[r3]                @ 0802B43A 6018  
          
          
@ ldrb  r0, VantageID
          @ strb  r0, [r3,#4] 
          
          
VantagePlus:
          eor r4,r5
          eor r5,r4
          eor r4,r5
          mov r1, #0x66 @crit
          mov r0, #0
          strh r0, [r4,r1]
          @mov r1, #0x68 @crit avoid
          @mov r0, #0
          @strh r0, [r4,r1]
          mov r1, #0x6A @battle crit
          mov r0, #0
          strh r0, [r4,r1]
          
          
Normal:

Alice · December 18, 2023, 10:57am

Thanks! I will try to test it