On a slightly different subject, I’d like to start submitting pull requests for skills I’ve ported if that’s alright with you? This system should start taking off faster if we can get most of the skills ported over. I’m still new to making skills in C so if you’re up for it, please let me know if there’s something I can improve 
have you named it as *.png ?
You may direct use command
find Contants/Gfx/Sources -type f -name '*.png'
to find whether your .png file is identified.
The skill name is actually separate to the skill description. The reason why kernel did not have a separate skill name is just because you did not give it a definition on name. Kernel may find the name from description when skill name does not exist. You just need to add the .name to the SkillInfo and then kernel may catch it.
PRs are acturally welcome as I acturally hope it to be a community project. To maintain the code quality, here I may quote from what StanH said in fe6 project:
As for style on coding, it is recommanded to obey on community consensus proposed by StanH
Can I get a working example of this to use as reference?
I’ve tried with and without quotes and the Kernel won’t accept it.
Yes and it is identified, but a 4bpp image isn’t generated without first cleaning the Kernel.
Shall I merge PR#18 ? I left some comments on that, it could be merged after you modify on them.
Now merged directly and fixed by commit 3db47ed
Nice, thanks.
I’ll start sending some of my other skill branches your way.
Now skill enum method is updated, if you want to add new skill, follow the updated DOC
1 Like
0.3.0 new version released
5 Likes
Congrats on the new release!
What’s next on your roadmap out of interest?
The TODO list what I can think of at the moment may be:
- Insert common hook lists before and post each attack in mapanim
- Modify on skill activation anim in mapanim
- Create more mapanim effects
- Create more cool UI skills at Post-action and pre-phase.
- Add some mordern items, such as Freeze
- Study on AI and add some AI related skills, such as Teleportation
3 Likes
Most of my branches have ended up too out of date to easily merge now. I’m just gonna redo them all.
This is really, really impresive and will hopefully enable more people to feel confident in creating and editing skill
Since I’m much more confident in my C skill than my assembler one (as I assume most people are !), I will try to contribute to the project, but I’m not sure about one details of the contributing guideline.
Does this part means that the final commit must have the new skill-index commented out ?
in my current PL I simply compiled the project with it commented out, and then uncommented for the final commit, but I could be wrong.
Yes you are correct.
New skill IDs should be commented out in PRs as which skills are enabled by default should be left up to Mokha.
Though all my PRs have had the skills enabled by default because there was room, but I’ll start following this from now own. 
1 Like
Ah, thanks for the information. I update pull request accordingly then
Hi, I’m trying to build a rom but I’m getting stuck at a step requiring Png2Dmp. I have it in the folder its asking for but I get this error:
make[1]: /home/sd9k/fe8u-cskillsys-kernel/Tools/EventAssembler/Tools/Png2Dmp: Permission denied
make[1]: *** [makefile:204: /home/sd9k/fe8u-cskillsys-kernel/Wizardry/Common/StrMagSplit/Data/SpiritDust.4bpp] Error 127
make: *** [makefile:27: all] Error 2
EDIT:
Checked the “Is executable” box in the permissions settings and now I’m getting this:
[GEN] /home/sd9k/fe8u-cskillsys-kernel/Wizardry/Common/StrMagSplit/Data/SpiritDust.4bpp
/home/sd9k/fe8u-cskillsys-kernel/Tools/EventAssembler/Tools/Png2Dmp: 1: MZ����@���: not found
/home/sd9k/fe8u-cskillsys-kernel/Tools/EventAssembler/Tools/Png2Dmp: 2: Syntax error: word unexpected (expecting “)”)
make[1]: *** [makefile:204: /home/sd9k/fe8u-cskillsys-kernel/Wizardry/Common/StrMagSplit/Data/SpiritDust.4bpp] Error 2
make: *** [makefile:27: all] Error 2
I’m running a fresh install of Kubuntu LTS
Hey there.
Try running make clean first, before running make.
That’s usually my issue with image related errors.
