We did not change anything except the usability judgement on DANCE, which means you need to do more work to adept to none-dancer characters for anim. But another similar skill effect as GoddessDance was originally created by kernel and can be used by everyone, which could be taken into consideration.
fe8u-cskillsys/docs/SkillInfo.md at main · FireEmblemUniverse/fe8u-cskillsys
#if defined(SID_Astra) && (COMMON_SKILL_VALID(SID_Astra))
if (actor == &gBattleActor && CheckBattleSkillActivate(actor, target, SID_Astra, actor->unit.spd * 3 / 4)) {
EnqueueRoundEfxSkill(SID_Astra);
gBattleActorGlobalFlag.skill_activated_astra = true;
result = result + SKILL_EFF0(SID_Astra);
}
#endif
Is this a functional way to change Astra’s activation chance or do I need to do something else? I noticed Aether says it activates by skill/2% but its formula just says:
(CheckBattleSkillActivate(attacker, defender, SID_Aether, attacker->unit.skl))
Is the division part done in a different place or is that just an outdated description and it’s just skill% now?
Also what specifically does I need to do to change which skills are placed in each of the 3 categories (equip, item, other)? Is skills.h the only thing I need to worry about?
Like for example if I wanted to move Infinity Edge to a different category in skills.h like this:
#define SID_InfinityEdge 0x10E → #define SID_InfinityEdge 0x0FC
Is that all it takes or do I need to change other files too?
For now, the skill description is accurate.
No, for custom-build, you should not directly change this file, skills.h is just an auto generated file.
The skill index is auto generated by three text files shown above. You should move the skill index from OTHERS to EQUIP
I wanted to divide Astra’s activation chance and Aether is the only proc skill that uses division to look at as an example. It says skill/2% in the skill description for Aether but in BattleDamage.c it only shows attacker->unit.skl the same as Corona, Luna, Ignis, etc. Is that an error or is there a different area or file where the dividing math is done?
Oh the description on Aether is wrong. I may fix it
So I’ve been playing around with this for quite a bit, however I’ve been having a very strange bug where characters are just suddenly able to use combat arts even though they are not even at the right rank to use them.
Like what will happen is that i will have a character not even have it and then after one attack they will a combat art.
This sounds like a serious bug. Could you please describe the scenario in more detail and what changes you made?
What makes this weird, I don’t even need to change much for this to even happen. I don’t know what triggers this bug for me, all I do is just use the version of FE Builder that’s in this thread and install the patch.
Doesn’t matter if I change anything with the game itself outside of that, this bug just happens.
At the moment, I’m not too sure what causes this.
Can you put a .ups and .sav file?
Sure how do i send them though? i haven’t done this in a while.
you can directly post the download link
Alright, i’ll just send though dropbox
Not sure if my testing was thorough, but I didn’t find any issues. Could you please describe in detail: which character, under what circumstances, obtained what combat skills? It would be best if there is a gif or video to help us identify the problem
Again, not doing anything noteworthy, I just attack the enemies and the combat arts just show up, and they’re useable.
Nothing is changed beyond having the patch applied.
Thanks for your assist, now we have offered a hotfix for this bug.
and thank you for the fix.
Who made the icons for the weapon arts?
I plan to add daggers as a weapon type and arts for it, so I was hoping there would be icons for daggers or I could get permission to edit the sword icons.
You can edit arts’ icon via “Art info” patch: docs/CombatArt.mdl. The patch is a little long, so you need to scroll down to see the icon button.
It is also looking forward if you could submit your work to the community repository. If you have any ideas, please let me know and I give the support.
